Skip to content

Comments

feat: use only material objects in geometry objects#250

Merged
mortenengen merged 4 commits intodevfrom
only-material-in-geometry
Jun 11, 2025
Merged

feat: use only material objects in geometry objects#250
mortenengen merged 4 commits intodevfrom
only-material-in-geometry

Conversation

@mortenengen
Copy link
Member

Removes the option to pass a constitutive law when creating a geometry. Instead, only material objects are allowed.

The following tasks were done:

  • Allow only material objects when creating geometry objects.
  • Add basic material objects with basic constitutive laws.
  • Update tests.

@mortenengen mortenengen added the enhancement New feature or request label May 15, 2025
@mortenengen mortenengen moved this to Needs review 📣 in PR tracker May 15, 2025
@mortenengen mortenengen marked this pull request as ready for review May 15, 2025 12:38
@mortenengen mortenengen requested a review from talledodiego May 15, 2025 12:38
Copy link
Collaborator

@talledodiego talledodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding job!
There are just a couple of minor comments for your consideration.

@mortenengen mortenengen moved this from Needs review 📣 to Changes requested 📝 in PR tracker May 28, 2025
@mortenengen mortenengen moved this from Changes requested 📝 to Review changes 🤔 in PR tracker Jun 8, 2025
@mortenengen mortenengen requested a review from talledodiego June 8, 2025 20:44
Copy link
Collaborator

@talledodiego talledodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! thanks for this modification!

@mortenengen mortenengen merged commit 7917556 into dev Jun 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Review changes 🤔 to Done 🚀 in PR tracker Jun 11, 2025
@mortenengen mortenengen deleted the only-material-in-geometry branch June 25, 2025 05:10
@mortenengen mortenengen linked an issue Nov 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

Access material properties from GenericSection instance

2 participants