fix: accept kwargs in the reinforcement factory#263
Merged
mortenengen merged 2 commits intodevfrom Aug 18, 2025
Merged
Conversation
talledodiego
approved these changes
Aug 8, 2025
Collaborator
talledodiego
left a comment
There was a problem hiding this comment.
Perfect. In the docstrings, it is customary to write something about kwargs?
Member
Author
Good question. In the factory for concretes we did not include anything, but for sure it would improve transparency to write a small note. I will do so in both factories before merging. Thanks for noting this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an inconsistency between the concrete factory and the reinforcement factory.
kwargslike for exampleconstitutive_laware now passed further to the specific reinforcement material.