Skip to content

Comments

fix: accept kwargs in the reinforcement factory#263

Merged
mortenengen merged 2 commits intodevfrom
accept-kwargs-reinf-factory
Aug 18, 2025
Merged

fix: accept kwargs in the reinforcement factory#263
mortenengen merged 2 commits intodevfrom
accept-kwargs-reinf-factory

Conversation

@mortenengen
Copy link
Member

This fixes an inconsistency between the concrete factory and the reinforcement factory. kwargs like for example constitutive_law are now passed further to the specific reinforcement material.

@mortenengen mortenengen added the bug Something isn't working label Aug 7, 2025
@mortenengen mortenengen moved this to Needs review 📣 in PR tracker Aug 7, 2025
Copy link
Collaborator

@talledodiego talledodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. In the docstrings, it is customary to write something about kwargs?

@mortenengen
Copy link
Member Author

Perfect. In the docstrings, it is customary to write something about kwargs?

Good question. In the factory for concretes we did not include anything, but for sure it would improve transparency to write a small note. I will do so in both factories before merging.

Thanks for noting this 👍

@mortenengen mortenengen moved this from Needs review 📣 to Changes requested 📝 in PR tracker Aug 8, 2025
@mortenengen mortenengen merged commit 6cb6746 into dev Aug 18, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Changes requested 📝 to Done 🚀 in PR tracker Aug 18, 2025
@mortenengen mortenengen deleted the accept-kwargs-reinf-factory branch August 26, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done 🚀

Development

Successfully merging this pull request may close these issues.

2 participants