Skip to content

fix: raise a deprecation warning if a GenericSection is created#344

Merged
mortenengen merged 1 commit intodevfrom
deprecation-warning-generic-section
Apr 14, 2026
Merged

fix: raise a deprecation warning if a GenericSection is created#344
mortenengen merged 1 commit intodevfrom
deprecation-warning-generic-section

Conversation

@mortenengen
Copy link
Copy Markdown
Member

@mortenengen mortenengen commented Apr 13, 2026

If a GenericSection is created, a DeprecationWarning is raised, and a BeamSection is created instead.

@mortenengen mortenengen added the enhancement New feature or request label Apr 13, 2026
@mortenengen mortenengen moved this to Under review 👀 in PR tracker Apr 13, 2026
@mortenengen mortenengen marked this pull request as ready for review April 13, 2026 19:41
talledodiego
talledodiego approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@talledodiego talledodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mortenengen mortenengen merged commit 13df387 into dev Apr 14, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Under review 👀 to Done 🚀 in PR tracker Apr 14, 2026
mortenengen added a commit that referenced this pull request Apr 14, 2026
@mortenengen
fix: use beam section in tests (#346)
df0f23a 
* chore: rename GenericSection and GenericSectionCalculator (#341)

* fix: add last point to complete domain in nm_interaction_domain (#342)

* fix: raise a DeprecationWarning for the GenericSection (#344)

* Use BeamSection instead of GenericSection in tests
@gabe-kafka gabe-kafka mentioned this pull request Apr 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talledodiego talledodiego talledodiego approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

PR tracker
Status: Done 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mortenengen @talledodiego