Add new report types and language support by MaciekR-Job · Pull Request #5 · fiberpay/regon-client

MaciekR-Job · 2026-01-19T15:27:50Z

Add new report types
Update methods: findByRegon, findByNip and findByKrs to support language parameter

…Report methods; add validateKrs method

Copilot

Pull request overview

This PR adds support for new report types related to civil partnerships and local units, and extends key lookup methods to support language selection for error messages.

Changes:

Added two new report type constants for legal persons (civil partnership partners and local units list)
Updated findByRegon, findByNip, and new findByKrs methods to accept a language parameter
Modified error message handling to return localized messages based on language selection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-19T17:39:29Z

     * @throws RegonServiceCallFailedException
     */
-    public function findByRegon(string $regon): array
+    public function findByRegon(string $regon, $lng = "pl"): array


The parameter $lng lacks type declaration. Add string type hint to ensure type safety and consistency with other parameters.

Copilot · 2026-01-19T17:39:30Z

     * @throws RegonServiceCallFailedException
     */
-    public function findByNip(string $nip): array
+    public function findByNip(string $nip, $lng = "pl"): array


The parameter $lng lacks type declaration. Add string type hint to ensure type safety and consistency with other parameters.

Copilot · 2026-01-19T17:39:30Z

+     * @throws EntityNotFoundException
+     * @throws RegonServiceCallFailedException
+     */
+    public function findByKrs(string $krs, $lng = "pl"): array


The parameter $lng lacks type declaration. Add string type hint to ensure type safety and consistency with other parameters.

Copilot · 2026-01-19T17:39:30Z

     * @throws RegonServiceCallFailedException
     */
-    private function findById($id, $value): array
+    private function findById($id, $value, $lng = "pl")


Parameters $id, $value, and $lng lack type declarations. Add type hints (string $id, string $value, string $lng) and return type annotation (: array) for type safety.

Copilot · 2026-01-19T17:39:30Z


    // data jako string w formacie YYYY-MM-DD
-    public function getCumulativeReport(string $date, string $collectiveReportType) {
+    public function getCumulativeReport(string $date, string $collectiveReportType, $lng = "pl"){


The parameter $lng lacks type declaration. Add string type hint to ensure type safety and consistency with other parameters.

Copilot · 2026-01-19T17:39:31Z

     * @throws RegonServiceCallFailedException|EntityNotFoundException
     */
-    public function getReport($regon, $reportType): array
+    public function getReport($regon, $reportType, $lng = "pl")


Parameters $regon, $reportType, and $lng lack type declarations. Add type hints (string $regon, string $reportType, string $lng) and return type annotation (: array) for type safety.

Copilot · 2026-01-19T17:39:31Z

            if (property_exists($data, 'ErrorCode')) {
-                if ($data->ErrorCode == "4") {
-                    throw new EntityNotFoundException($data->ErrorMessagePL);
+                $error = $lng === "pl" ?  $data->ErrorMessagePl : $data->ErrorMessageEn;


The language parameter accepts any string value without validation. Consider validating that $lng is either 'pl' or 'en' to prevent unexpected behavior when an invalid language code is provided.

jedrzejjarocki · 2026-01-19T17:42:36Z

@copilot, fix php docs and rename $lng to $language

Copilot · 2026-01-19T17:42:46Z

@jedrzejjarocki I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: jedrzejjarocki <46086567+jedrzejjarocki@users.noreply.github.com>

Rename $lng to $language and add type hints

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T16:49:49Z

+            if (!in_array($reportType, [self::REPORT_TYPE_NATURAL_PERSON_PKD, self::REPORT_TYPE_LEGAL_PERSON_PKD,
+                self::REPORT_TYPE_LEGAL_PERSON_CIVIL_PARTNERSHIP_PARTNERS, self::REPORT_TYPE_LEGAL_PERSON_LOCAL_UNITS_LIST
+            ])) {


This array contains multiple report types that require special handling. Consider extracting this list to a class constant (e.g., REPORT_TYPES_REQUIRING_ARRAY_NORMALIZATION) to improve maintainability and make the purpose clearer.

MaciekR-Job added 3 commits January 19, 2026 16:15

update handleSoapFault method return type to 'never'

1c15949

add new report types for legal persons and update valid reports list

0da7a9b

add support for language parameter in findByRegon, findByNip, and get…

885ffab

…Report methods; add validateKrs method

MaciekR-Job requested a review from jedrzejjarocki January 19, 2026 15:27

jedrzejjarocki requested a review from Copilot January 19, 2026 17:37

Copilot AI reviewed Jan 19, 2026

View reviewed changes

Initial plan

6d87159

Copilot AI mentioned this pull request Jan 19, 2026

Rename $lng to $language and add type hints #6

Merged

Copilot AI and others added 4 commits January 19, 2026 17:45

Rename $lng to $language and fix PHP docs

400b8f0

Co-authored-by: jedrzejjarocki <46086567+jedrzejjarocki@users.noreply.github.com>

Add type hints to validation methods for consistency

50bd969

Co-authored-by: jedrzejjarocki <46086567+jedrzejjarocki@users.noreply.github.com>

Fix code formatting - add blank line between methods

59c637b

Co-authored-by: jedrzejjarocki <46086567+jedrzejjarocki@users.noreply.github.com>

Merge pull request #6 from fiberpay/copilot/sub-pr-5

502b360

Rename $lng to $language and add type hints

jedrzejjarocki requested a review from Copilot January 21, 2026 16:49

Copilot AI reviewed Jan 21, 2026

View reviewed changes

jedrzejjarocki approved these changes Jan 21, 2026

View reviewed changes

jedrzejjarocki merged commit 68bdba5 into main Jan 21, 2026

Conversation

MaciekR-Job commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

jedrzejjarocki commented Jan 19, 2026

Uh oh!

Copilot AI commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants