Merged
Conversation
dorukkilitcioglu
approved these changes
Jul 14, 2022
Contributor
There was a problem hiding this comment.
All good from my side. Perhaps not important for now, but might be possible to explore Windows compilation as well: https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/
Contributor
Author
Thanks @dorukkilitcioglu , there shows a comprehensive VC components and build tools in the list. I will look into this. Update: The Github actions are updated to test different platforms: ubuntu, macos and windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is to fix a compiling issue in using Visual Studio C++ compiler. This issue was observed by Danielle initially when we pip install seq2pat on Windows with a compiler in Visual Studio C++ Build Tools.
The issue is
error code C2668: `fpclassify`: ambiguous call to overloaded function, which is caused by theisnanfunction introduced in my last commit. This function doesn't cause the issue in my tests on Mac using Clang 10.0.0.This seems to be a known issue with VC compiler and the solution can be referred to a discussion here. Later on, we would need to have a test on Windows once backend gets updated.