remove unused fs placeholder dependency#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ci-queuedeclaredfs@^0.0.1-securityas a runtime dependency.fsis a Node.js built-in core module — theimport { writeFileSync } from 'fs'/from 'node:fs'calls injavascript/srcalways resolve to the core module, never to an npm package. The npmfspackage at0.0.1-securityis npm's empty security placeholder (no code, no install scripts, no dependencies) published to neutralize the squatted name. It is harmless but completely unused, so this removes it frompackage.jsonandpackage-lock.json.This dependency also propagates into consumers (it currently shows up in figma/figma's
pnpm-lock.yamlvia the ci-queue dependency), so removing it here drops the noise downstream once the ci-queue pin is bumped.No behavior change —
fsimports continue to resolve to the Node core module.Test Plan
npm installregenerates the lockfile cleanly with nofsentrynpm run build(tsc) succeeds —fs/node:fsimports compile against the Node built-innpm testresults unchanged vs. master (pre-existing, unrelated test-suite failures present on master before this change)