feat: implement access, blob/replicate, and pdp/* capabilities#28
Merged
Conversation
- required for piri migration to ucan1
- because external dep github.com/filecoin-project/go-data-segment/merkletree doesn't support dagjson, and we don't use dagjson for anything
frrist
commented
May 20, 2026
| // CBOR-only on the wire, so we don't generate dag-json codecs here. | ||
| if err := cbg.WriteMapEncodersToFile(cborFile, "pdp", models...); err != nil { | ||
| panic(err) | ||
| } |
Member
Author
There was a problem hiding this comment.
@alanshaw want to flag this explicitly: the github.com/filecoin-project/go-data-segment/merkletree dependency we have doesn't implement DAGJSON, it does implement a CBOR-Un/Marshaller. The only alterntive I see is wrapping/re-implementing the type, and I'd like to avoid that if alright?
frrist
commented
May 20, 2026
Comment on lines
+44
to
+45
| // The stack is CBOR-only on the wire, so we don't generate dag-json codecs. | ||
| if err := cbg.WriteMapEncodersToFile(cborFile, "sign", models...); err != nil { |
Member
Author
There was a problem hiding this comment.
ditto no json note here too.
alanshaw
approved these changes
May 21, 2026
frrist
added a commit
to fil-forge/ucantone
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.