Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

switch to node-based server#295

Merged
scottjehl merged 4 commits intofilamentgroup:masterfrom
c-vetter:master
Feb 28, 2019
Merged

switch to node-based server#295
scottjehl merged 4 commits intofilamentgroup:masterfrom
c-vetter:master

Conversation

@c-vetter
Copy link
Copy Markdown
Contributor

Hey there 👋🙂
I wanted to contribute to loadCSS, but find the requirement for PHP to be counterproductive. Therefore, I implemented a simple server script to replace PHP. Just run it with npm start and open localhost:3000.

If you like this, would you be interested in further modernization, like automated tests using Nightmare, and a grunt-less build/test setup, eslint? If so, I'd happily lend a hand here.

also, some cleanup
@scottjehl
Copy link
Copy Markdown
Member

This looks great to me, thanks.

One question though: I pulled your branch, npm installed and ran npm start as noted.

I see an error: Cannot find module 'fs-extra'

Thoughts?

@c-vetter
Copy link
Copy Markdown
Contributor Author

Yes, I had used fs-extra during development, but found that it wasn't necessary, so I removed it from package.json. I forgot to remove the reference to it. That's fixed now 👍

@c-vetter
Copy link
Copy Markdown
Contributor Author

I was also lacking a semicolon 🤔 how do you think about linting as a pre-commit-hook?

@scottjehl
Copy link
Copy Markdown
Member

Okay great. And yeah pre-commit linting sounds like a good idea. Thanks!

@c-vetter
Copy link
Copy Markdown
Contributor Author

Here you go 😄🎉
Gotta love husky 🙃

@scottjehl
Copy link
Copy Markdown
Member

Seems to do the trick now! I think we'll want to clean up some links to the test pages here since they seem to use absolute references but I can get those after landing.

@scottjehl scottjehl merged commit 1b0b105 into filamentgroup:master Feb 28, 2019
@scottjehl
Copy link
Copy Markdown
Member

cheers thanks!

@c-vetter
Copy link
Copy Markdown
Contributor Author

Seems to do the trick now! I think we'll want to clean up some links to the test pages here since they seem to use absolute references but I can get those after landing.

Oh yeah, didn't check all those 🤔
Thanks for taking care of them 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants