Fix refreshFormData with Enum#10554
Merged
Merged
Conversation
Member
|
When the form is first loaded, the value is an enum instead of a string. Right? |
Contributor
Author
|
Nope, the first time the component is loaded with the form, it is indeed a string, even if the field is of type Enum. The issue only occurs when using the refreshFormData function with a casted Enum field. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you use refreshFormData on values that are cast as Enums in the Model, the enum will be loaded instead of its value, which will cause a problem when submitting the form.
My PR fixes this problem by iterating through the values to refresh and taking ->value in the case of an Enum.
The solution is certainly not perfect for Filament's framework.
I'll let the experts correct this properly :)
Code style
composer cscommand has been run.Testing
See my previous comment for this.