Fix: skip relationship query when Repeater has no parent model#19906
Merged
danharrin merged 2 commits intoMay 25, 2026
Merged
Conversation
0960832 to
ee38eb1
Compare
danharrin
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A
Repeaterwith->relationship()queries the related table on a Create page even though no parent model exists yet.getCachedExistingRecords()does not short-circuit when there is no model, so it runsselect * from "posts" where "posts"."author_id" is null and "posts"."author_id" is not null— one redundant query per relationship Repeater per create-page render. Fixed by short-circuiting when there is no persisted model, mirroringEntanglesStateWithSingularRelationshipwhich already guards with! $record?->exists.Reproduction: https://github.com/FS-Baz/filament-repeater-repro
Visual changes
None — internal behavior only, no UI change.
Functional changes
composer cscommand.