Fix broken filterTable testing helper#3139
Merged
danharrin merged 4 commits intoJul 17, 2022
Merged
Conversation
Member
|
Thanks, I've added another test for this too |
Contributor
Author
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to use the
filterTable()testing helper in the way described in the docs for anything other than a basicFilterfilter)filament/packages/tables/docs/06-testing.md
Lines 114 to 130 in c104493
This is due to a few incorrect parameter/return types referencing
Filterinstead ofBaseFilter. This PR fixes those.May also be worth it to document the usage of testing a
MultiSelectFilterwith an example by passing in an array, although I'll leave this one for the reviewer to decide and implement how they wish.