Support full screen modals#3911
Merged
danharrin merged 12 commits intoSep 10, 2022
Merged
Conversation
zepfietje
suggested changes
Sep 8, 2022
zepfietje
suggested changes
Sep 8, 2022
6 tasks
Contributor
Author
|
Ugh. I think I botched this. This PR was created off of a fork so I can't merge the database-notifications PR into my fork. Or can I? Not sure how to do that. I can close this PR and submit a new PR that does have the merge and changes for this. Went ahead and committed the necessary changes here for when the database-notifications is merged. Let me know what to do? |
danharrin
changed the base branch from
2.x
to
feature/database-notifications
Member
|
I've changed this PR to target the database notifications branch. Now you can see the merge conflict that would happen if we merged this into 2.x with those modal changes. Can you fix the problem? |
…Screen to match slideOut implementation
Contributor
Author
|
See if this works for you. Seems like either way this will need to wait for the database-notifications to get merged first. |
Member
|
Perfect, thanks @awcodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to make modals full screen with ->modalWidth('screen')