Added Htmlable Support For TableHeader.#4307
Merged
danharrin merged 7 commits intoOct 7, 2022
Merged
Conversation
Always making view, and pass it as table header is not something we want all time as we can use htmlstring in filament. So I add support for this. Also i see there may be issue with table headeraction, So what i have done , If the table header pass as argument is Illuminate\Support\HtmlString, I just added the action with the heading.
Member
|
Your IDE has made hundreds of formatting changes, please revert them |
Contributor
Author
Yes, Sorry for that. |
Z3d0X
reviewed
Oct 2, 2022
Co-authored-by: ZedoX <75579178+Z3d0X@users.noreply.github.com>
Member
|
We should actually support Htmlable in the |
Member
|
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always making view, and pass it as table header is not something we want all time as we can use htmlstring in filament.
So I add support for this.
Also i see there may be issue with table headeraction, So what i have done , If the table header pass as argument is Illuminate\Support\HtmlString, I just added the action with the heading.
Here is an demo what it look like.
