Skip to content

Fix: overflow issues on html, body with modals#5658

Merged
danharrin merged 1 commit into
2.xfrom
fix/overflow-modal-issues
Feb 13, 2023
Merged

Fix: overflow issues on html, body with modals#5658
danharrin merged 1 commit into
2.xfrom
fix/overflow-modal-issues

Conversation

@awcodes
Copy link
Copy Markdown
Contributor

@awcodes awcodes commented Feb 13, 2023

This fixes bug which would have been created by #5647 while maintaining fix for original issue of modals not scrolling on mobile devices.

@awcodes awcodes added the bug Something isn't working label Feb 13, 2023
@awcodes awcodes added this to the v2 milestone Feb 13, 2023
@awcodes awcodes self-assigned this Feb 13, 2023
@what-the-diff
Copy link
Copy Markdown
Contributor

what-the-diff Bot commented Feb 13, 2023

  • Changed the height of app.blade.php from min-h-full to h-full
  • Added overflow: auto; in base layout for body tag

@danharrin danharrin merged commit e0c358a into 2.x Feb 13, 2023
@danharrin
Copy link
Copy Markdown
Member

danharrin commented Feb 13, 2023

Thanks!

@danharrin danharrin deleted the fix/overflow-modal-issues branch February 13, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@awcodes awcodes

Labels

bug Something isn't working

Projects

None yet

Milestone

v2

Development

Successfully merging this pull request may close these issues.

2 participants

@awcodes @danharrin