Skip to content

Add missing trailing commas#5801

Merged
danharrin merged 1 commit into
2.xfrom
add-missing-trailing-commas
Feb 27, 2023
Merged

Add missing trailing commas#5801
danharrin merged 1 commit into
2.xfrom
add-missing-trailing-commas

Conversation

@zepfietje
Copy link
Copy Markdown
Member

@zepfietje zepfietje commented Feb 27, 2023

No description provided.

@zepfietje zepfietje added this to the v2 milestone Feb 27, 2023
@zepfietje zepfietje requested a review from danharrin February 27, 2023 13:10
@what-the-diff
Copy link
Copy Markdown
Contributor

what-the-diff Bot commented Feb 27, 2023

  • The emit and emitUp methods now have a trailing comma in the parameter list.
  • In both functions, $data is no longer optional (it has been removed from the function signature).

@danharrin danharrin merged commit 19ba32f into 2.x Feb 27, 2023
@danharrin danharrin deleted the add-missing-trailing-commas branch February 27, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees

No one assigned

Labels

code quality task

Projects

None yet

Milestone

v2

Development

Successfully merging this pull request may close these issues.

2 participants

@zepfietje @danharrin