Fix code style on PRs by zepfietje · Pull Request #6534 · filamentphp/filament

zepfietje · 2023-05-17T09:02:02Z

Makes it easier to review PRs when we fix code style on PR already instead of after merge.

Changes have been thoroughly tested to not break existing functionality.
New functionality has been documented or existing documentation has been updated to reflect changes.
Visual changes are explained in the PR description using a screenshot/recording of before and after.

what-the-diff · 2023-05-17T09:02:25Z

PR Summary

Update fix-code-style.yml triggers
The fix-code-style.yml file now runs on both push and pull_request events.
Modify npm-build.yml to run on PR closed
The npm-build.yml file now runs when a pull request is closed, not just when it's merged.

zepfietje added 2 commits May 17, 2023 11:01

Fix code style on PRs

1940e13

Clean up

cfbd93c

zepfietje changed the title ~~Fix code style on prs~~ Fix code style on PRs May 17, 2023

zepfietje added the task label May 17, 2023

zepfietje added this to the v2 milestone May 17, 2023

danharrin merged commit bda92c5 into 2.x May 17, 2023

danharrin deleted the fix-code-style-on-prs branch May 17, 2023 09:57