Skip to content

Allow pagination to be used as livewire component#6540

Merged
danharrin merged 1 commit into
filamentphp:2.xfrom
howdu:patch-2
May 17, 2023
Merged

Allow pagination to be used as livewire component#6540
danharrin merged 1 commit into
filamentphp:2.xfrom
howdu:patch-2

Conversation

@howdu
Copy link
Copy Markdown
Contributor

@howdu howdu commented May 17, 2023

Inside a custom livewire component I wanted to reuse the Filament pagination {{ $example->links('tables::components.pagination.index') }}

This change prevented error:

count(): Argument #1 ($value) must be of type Countable|array null given

@what-the-diff
Copy link
Copy Markdown
Contributor

what-the-diff Bot commented May 17, 2023

  • The recordsPerPageSelectOptions prop is now optional.

@danharrin danharrin merged commit 4a37124 into filamentphp:2.x May 17, 2023
@danharrin danharrin added the bug Something isn't working label May 17, 2023
@zepfietje zepfietje added this to the v2 milestone May 17, 2023
@howdu howdu deleted the patch-2 branch May 17, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants