Skip to content

fix: EditProfile - debounce password change update requests #7526

Merged
danharrin merged 2 commits into
filamentphp:3.xfrom
DanielSpravtsev:DanielSpravtsev-patch-1
Aug 7, 2023
Merged

fix: EditProfile - debounce password change update requests #7526
danharrin merged 2 commits into
filamentphp:3.xfrom
DanielSpravtsev:DanielSpravtsev-patch-1

Conversation

@DanielSpravtsev
Copy link
Copy Markdown
Contributor

  • Changes have been thoroughly tested to not break existing functionality.

Changed TextInput::make('password')->live() to debounce() for reducing update requests to the server

@what-the-diff
Copy link
Copy Markdown
Contributor

what-the-diff Bot commented Aug 7, 2023

PR Summary

  • Modification of live Method in the EditProfile.php
    The 'live' method in the 'EditProfile.php' file, which is used for generating password forms, has been tweaked. The key change here is the incorporation of a 'debounce' parameter. This addition aims to smoother the live interactions by delaying the processing time of certain actions, thus improving the overall user experience. The delay time specified here is 500 (units not specified, usually milliseconds).

Comment thread packages/panels/src/Pages/Auth/EditProfile.php Outdated
@danharrin danharrin added the enhancement New feature or request label Aug 7, 2023
@danharrin danharrin added this to the v3 milestone Aug 7, 2023
@danharrin danharrin merged commit 51e12f3 into filamentphp:3.x Aug 7, 2023
@DanielSpravtsev DanielSpravtsev deleted the DanielSpravtsev-patch-1 branch August 8, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants