Skip to content

Disable registering certain resources to navigation#804

Merged
danharrin merged 5 commits intofilamentphp:2.xfrom
sawirricardo:2.x
Dec 11, 2021
Merged

Disable registering certain resources to navigation#804
danharrin merged 5 commits intofilamentphp:2.xfrom
sawirricardo:2.x

Conversation

@sawirricardo
Copy link
Copy Markdown
Contributor

Currently, the way to disable resources is to add this

public static  function registerNavigationItems(): void
    {
        return;
    }

ref: https://discord.com/channels/883083792112300104/883085267383226478/918873716782403615

However, as discussed in Discord, ideally we can use static property directly.

@danharrin
Copy link
Copy Markdown
Member

Hey, this looks good. Maybe add this to the Resources docs though, as the Navigation docs should be solely about the actual Navigation API IMO. Thoughts?

@danharrin danharrin added enhancement New feature or request pending changes labels Dec 10, 2021
@sawirricardo
Copy link
Copy Markdown
Contributor Author

Hey, this looks good. Maybe add this to the Resources docs though, as the Navigation docs should be solely about the actual Navigation API IMO. Thoughts?

Agree @danharrin

@danharrin danharrin merged commit a55de18 into filamentphp:2.x Dec 11, 2021
@danharrin
Copy link
Copy Markdown
Member

Thanks! I've just added the same API to custom pages, so moved the docs back to the Navigation section :)

@sawirricardo
Copy link
Copy Markdown
Contributor Author

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants