Use a temporary url for private uploads#810
Merged
danharrin merged 2 commits intofilamentphp:2.xfrom Dec 11, 2021
martin-ro:patch-2
Merged
Use a temporary url for private uploads#810danharrin merged 2 commits intofilamentphp:2.xfrom martin-ro:patch-2
danharrin merged 2 commits intofilamentphp:2.xfrom
martin-ro:patch-2
Conversation
If we upload a private file to S3 we should use a signed temporary URL for the preview to work. See: https://github.com/laravel-filament/filament/blob/fca0ea26c1166ce405c5e8eda12dea85a3900282/packages/forms/src/Components/FileUpload.php#L471
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we upload a private file to S3 we should use a signed temporary URL for the preview to work.
See: https://github.com/laravel-filament/filament/blob/fca0ea26c1166ce405c5e8eda12dea85a3900282/packages/forms/src/Components/FileUpload.php#L471