Skip to content

[Plugin] Filament 2FA #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saade merged 11 commits into from
Sep 9, 2024
Merged

[Plugin] Filament 2FA #509

saade merged 11 commits into from
Sep 9, 2024

Conversation

@Baspa
Copy link
Contributor

@Baspa Baspa commented Aug 16, 2024

No description provided.

@Baspa Baspa requested a review from saade as a code owner August 16, 2024 13:51
@Baspa Baspa changed the title [Plugin] Filament Two Factor Auth [Plugin] Filament 2FA Aug 23, 2024
saade
saade requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Could you please ensure that image URLs in your plugin's README file are absolute URLs rather than relative links? Then we can embed them on our website correctly.

Also, please make sure that your plugin image focus on your plugin functionality rather than a simple screenshot of an entire panel. You could also use Beyond Code's banner generator to generate them.

Please let us know when you've addressed these issues.

@Baspa
Copy link
Contributor Author

Baspa commented Aug 31, 2024

Hey @saade, I fixed the URLs in the package and also changed the image in this PR. It's a PNG, is that a problem? Or do you want me to convert it to a JPG?

@Baspa Baspa requested a review from saade August 31, 2024 05:21
saade
saade requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Could you please ensure that image URLs in your plugin's README file are absolute URLs rather than relative links? Then we can embed them on our website correctly. Thanks!

Please let us know when you've addressed these issues.

@saade
Copy link
Member

saade commented Sep 6, 2024

Hey @saade, I fixed the URLs in the package and also changed the image in this PR. It's a PNG, is that a problem? Or do you want me to convert it to a JPG?

not a problem.

@saade saade marked this pull request as draft September 6, 2024 14:30
@Baspa
Copy link
Contributor Author

Baspa commented Sep 6, 2024

Hey! Could you please ensure that image URLs in your plugin's README file are absolute URLs rather than relative links? Then we can embed them on our website correctly. Thanks!

Please let us know when you've addressed these issues.

I believe all images are already absolute URLs right now?

@Baspa Baspa requested a review from saade September 6, 2024 17:28
@saade
Copy link
Member

saade commented Sep 7, 2024

They're not, here's an example of a raw url
https://raw.githubusercontent.com/vormkracht10/filament-2fa/main/docs/two-factor-page.png

@saade saade marked this pull request as ready for review September 7, 2024 23:46
@Baspa
Copy link
Contributor Author

Baspa commented Sep 8, 2024

Ah excuse me, didn't know that. I fixed them! @saade

@saade saade merged commit c9ca093 into filamentphp:main Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saade saade saade approved these changes

Assignees

No one assigned

Labels

changes requested new author new plugin

Projects

Website content submissions
Status: Published

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Baspa @saade