Skip to content

Conversation

@pxlrbt
Copy link
Member

@pxlrbt pxlrbt commented Jun 13, 2025

image

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the plugin list filter by removing the v1.x option and adding support for v4.x, and adjusts the selector highlight positioning accordingly.

  • Removed the v1.x filter button
  • Added a new v4.x filter button
  • Updated translation classes to map v3→v4 for the highlight background
Comments suppressed due to low confidence (3)

resources/views/components/plugins/list.blade.php:178

  • [nitpick] The version buttons are hard-coded and repeated; consider driving them from a single versions array and using a loop to render each button, which will reduce duplication and make future updates easier.
<div class="relative z-10 inline-flex select-none items-center gap-2.5 rounded-full bg-white p-[.55rem] font-medium shadow-lg shadow-black/[0.01]">

resources/views/components/plugins/list.blade.php:201

  • There aren’t any tests covering the new v4.x filter behavior. Adding unit or integration tests to verify that selecting v4.x updates selectedVersion and filters correctly would help prevent regressions.
<div

resources/views/components/plugins/list.blade.php:178

  • The filter buttons currently lack ARIA roles and state indicators; consider adding role="tablist" on the container and role="tab" plus aria-selected on each button to improve screen-reader accessibility.
<div class="relative z-10 inline-flex select-none items-center gap-2.5 rounded-full bg-white p-[.55rem] font-medium shadow-lg shadow-black/[0.01]">

@danharrin danharrin merged commit 8c39729 into main Jun 13, 2025
2 checks passed
@danharrin danharrin deleted the feature/plugins-v4 branch June 13, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants