Skip to content

change default settings file #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

change default settings file #2215

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82613a7
change default settings file
EDIflyer Nov 11, 2022
7377aa5
change to /database.db to match default
EDIflyer Nov 11, 2022
b3bbf8c
Merge branch 'master' into patch-1
EDIflyer Dec 11, 2022
559f887
Merge branch 'master' into patch-1
EDIflyer Feb 16, 2023
f9d7f90
Merge branch 'master' into patch-1
EDIflyer Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/root/defaults/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
"baseURL": "",
"address": "",
"log": "stdout",
"database": "/database/filebrowser.db",
Copy link
Member

@o1egl o1egl Feb 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This settings file is related to the linuxserver based container and the path of the file is set correctly

Copy link
Author

@EDIflyer EDIflyer Feb 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be changed elsewhere then? The documentation seemed to vary between /database/filebrowser.db and /database.db? For example what caught me out was the Alpine example at https://filebrowser.org/installation#docker uses /database.db but then the text below to the sample config file at https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json is then /database/filebrowser.db? Perhaps it just needs some text added to make it clear you need to change the sample config file to match? (I'll confess when I first set things up I had a mismatch and it took me a while to work out what was going on!). I think if you don't have a config file it seems to default to expect /database.db?

Copy link
Member

@o1egl o1egl Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the default docker image https://github.com/filebrowser/filebrowser/blob/master/Dockerfile uses the https://github.com/filebrowser/filebrowser/blob/master/docker_config.json for config. The file you are referring to is used in the linuxserver based image. But I agree that the docs need to be changed. Feel free to make a PR

Copy link
Author

@EDIflyer EDIflyer Jun 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll try to look hopefully this weekend (PS just synced my fork but it seemed to appear as ready to merge but not changed yet - will post when it is!)

Copy link
Author

@EDIflyer EDIflyer Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - got round to it in filebrowser/docs#52 by tweaking the docs very slightly

"database": "/database.db",
"root": "/srv"
}
}