fix(preview): let arrow keys seek video instead of switching files#5895
Merged
hacdias merged 1 commit intofilebrowser:masterfrom Apr 11, 2026
Merged
fix(preview): let arrow keys seek video instead of switching files#5895hacdias merged 1 commit intofilebrowser:masterfrom
hacdias merged 1 commit intofilebrowser:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When previewing a video in a folder containing more than one file, pressing the left/right arrow keys switches to the previous/next file instead of seeking the video. This makes it impossible to use the keyboard to seek videos in any folder with multiple items — single-video folders work because there is nothing to switch to, so the event falls through to video.js.
The root cause is in
frontend/src/views/files/Preview.vue: thekeyhandler unconditionally mapsArrowLeft/ArrowRighttoprev()/next()without checking the current file type, so video.js never gets a chance to handle them.Additional Information
This PR adds a small guard: when the current preview is a video (
fileStore.req?.type === "video"),ArrowLeftandArrowRightreturn early and the event falls through to video.js for seeking.Enteris preserved as an "advance to next file" shortcut so multi-video folders still have a keyboard way to switch, andEscis unchanged.Behavior summary:
Related discussion: #4908 (video player improvements).
Checklist
masterbranch.