Skip to content

Conversation

@dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 10, 2021

Fixes #153
Implements the Push Channel tests for #154

@dirkmc dirkmc force-pushed the test/auto-restart-push branch 2 times, most recently from 3ed5718 to e9b629e Compare March 11, 2021 16:35
@dirkmc dirkmc force-pushed the test/auto-restart-push branch from e9b629e to 7b97f78 Compare March 12, 2021 08:42
@dirkmc dirkmc changed the title Add tests for auto-restarting a push channel Improve push channel to detect when not all data has been received Mar 12, 2021
@dirkmc dirkmc force-pushed the test/auto-restart-push branch from 7b97f78 to 740baee Compare March 12, 2021 09:09
@dirkmc dirkmc marked this pull request as ready for review March 12, 2021 09:09
@dirkmc dirkmc requested review from nonsense and raulk March 12, 2021 09:09
@dirkmc dirkmc force-pushed the test/auto-restart-push branch from 740baee to aeb7d36 Compare March 12, 2021 09:40
@dirkmc dirkmc force-pushed the test/auto-restart-push branch from aeb7d36 to 733e6f5 Compare March 12, 2021 09:44
Copy link
Member

@nonsense nonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm!

@dirkmc dirkmc merged commit 42e0a5b into master Mar 15, 2021
@dirkmc dirkmc deleted the test/auto-restart-push branch March 15, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push channel monitor doesn't detect when not all data received

3 participants