Better reconnect behaviour #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 65.78% 65.82% +0.03%
==========================================
Files 23 23
Lines 2455 2446 -9
==========================================
- Hits 1615 1610 -5
Misses 506 506
+ Partials 334 330 -4
Continue to review full report at Codecov.
|
| const ErrUnsupported = errorType("unsupported") | ||
|
|
||
| // ErrDisconnected indicates the other peer may have hung up and you should try restarting the channel. | ||
| const ErrDisconnected = errorType("other peer appears to have hung up. restart Channel") |
There was a problem hiding this comment.
ErrDisconnected and ErrRemoved are no longer used (with this PR we try to reconnect automatically)
| return err | ||
| } | ||
|
|
||
| m.reconnectsLk.RLock() |
There was a problem hiding this comment.
Remove code that watches for the connection going down and coming up again, this is now handled by the channel monitor
| testutil.AssertFakeDTVoucher(t, receivedRequest, h.voucher) | ||
| }, | ||
| }, | ||
| "Remove Timed-out request": { |
There was a problem hiding this comment.
These tests were for connection monitoring, which has now been removed in favour of the push / pull channel monitors
| defer t.dataLock.Unlock() | ||
|
|
||
| chid, ok := t.graphsyncRequestMap[graphsyncKey{request.ID(), p}] | ||
| if ok { |
There was a problem hiding this comment.
Firing a Disconnect event here would cause go-fil-markets to fail the deal.
Instead we fire a SendDataError which the push / pull monitor listen for - they will attempt to reconnect and restart the channel
Fixes #160 #154 #156