Refactor GenerateKey API for testing only
#163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
approved these changes
Apr 15, 2024
Remove `GenerateKey` API from `gpbft.Signer` interface, and change the signing backend implementations to expose this capability for testing purposes only. This change reduces the surface of exported API at the core `gpbft` package. Signing test suit is refactored to use testify built-in utilities and moved out of the production scope. The default hasher for fake signing backed is also changed to SHA-256, a built-in hasher, in favour of reducing the dependency footprint. Fixes #154
masih
force-pushed
the
masih/refctr-generate-key-api
branch
from
ab52522 to
76d9a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
GenerateKeyAPI fromgpbft.Signerinterface, and change the signing backend implementations to expose this capability for testing purposes only.This change reduces the surface of exported API at the core
gpbftpackage.Signing test suit is refactored to use testify built-in utilities and moved out of the production scope.
The default hasher for fake signing backed is also changed to SHA-256, a built-in hasher, in favour of reducing the dependency footprint.
Fixes #154