Introduce additional simulation options and restructure constants #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the simulation initialization to accept a variable number of Option arguments. These options transform constants into adjustable parameters, such as the latency model, enabling a versatile combination of simulation scenarios. Update the test suite to reflect these changes, eliminating redundant code. Convert dedicated tests into table tests, which now include basic tests covering BLS, non-BLS, agreement, and split convergence onto the base chain. Refactor no-latency, also known as sync tests, to explicitly utilize a latency.None model, enhancing clarity. Restructure adversary instantiation within a Generator. This change streamlines the adversary API, allowing it to leverage the existing gpbft API for initiating adversary logic, and obviates the need for specific Begin functions previously invoked sporadically across tests. Additionally, introducing generators enables the simulation API to present a fixed set of receivers and privatize most fields and receiver functions, minimizing potential errors when utilizing simulation APIs. The current revisions include several TODO markers for future enhancements to maintain a manageable scope of changes in this pull request. The refactoring facilitates the future addition of probabilistic adversary populations and probabilistic ec chain mutations, with implementation details to follow in subsequent PRs.
masih
changed the title
Kubuxu
reviewed
Apr 29, 2024
| opts.graniteConfig = &defaultGraniteConfig | ||
| } | ||
| if opts.signingBacked == nil { | ||
| opts.signingBacked = signing.NewFakeBackend() |
Contributor
There was a problem hiding this comment.
BLS envvar override is missing
Member
Author
There was a problem hiding this comment.
Moved to f3sim command as it is the entrypoint to running a simulation.
Does that make sense?
Contributor
There was a problem hiding this comment.
When working on BLS, I used it to run all the tests with BLS as a final sanity check.
Member
Author
There was a problem hiding this comment.
Noted. I'll make sure that env var is respected in test scope.
Kubuxu
approved these changes
Apr 29, 2024
Contributor
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
Apart from the one comment, SGWM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the simulation initialization to accept a variable number of Option arguments. These options transform constants into adjustable parameters, such as the latency model, enabling a versatile combination of simulation scenarios.
Update the test suite to reflect these changes, eliminating redundant code. Convert dedicated tests into table tests, which now include basic tests covering BLS, non-BLS, agreement, and split convergence onto the base chain.
Refactor no-latency, also known as sync tests, to explicitly utilize a latency.None model, enhancing clarity.
Restructure adversary instantiation within a Generator. This change streamlines the adversary API, allowing it to leverage the existing gpbft API for initiating adversary logic, and obviates the need for specific Begin functions previously invoked sporadically across tests. Additionally, introducing generators enables the simulation API to present a fixed set of receivers and privatize most fields and receiver functions, minimizing potential errors when utilizing simulation APIs.
The current revisions include several TODO markers for future enhancements to maintain a manageable scope of changes in this pull request. The refactoring facilitates the future addition of probabilistic adversary populations and probabilistic ec chain mutations, with implementation details to follow in subsequent PRs.