Add unit tests for simulation message queue #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masih
force-pushed
the
masih/sim-msg-queue-tests
branch
from
dca4d8b to
711fba4
Compare
Assert that simulation priority queue used to order message delivery is behaving as expected: * queued messages are sorted in ascending order of their `deliverAt`. * removal of a message returns the one with earliest `deliverAt`. * conditional upsert is respected. * duplicate messages are allowed and ordered as expected. * queue is fully drained upon removing all messages. Update misleading godoc for `Pop` receiver. Addresses #209 (comment)
masih
force-pushed
the
masih/sim-msg-queue-tests
branch
from
711fba4 to
fa96da7
Compare
Kubuxu
reviewed
May 15, 2024
| }, | ||
| } | ||
| for _, test := range tests { | ||
| test := test |
Contributor
There was a problem hiding this comment.
Do we require Go 1.22? If so this is no longer required.
Contributor
There was a problem hiding this comment.
Ok, no, looks like we are on Go 1.21
Kubuxu
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that simulation priority queue used to order message delivery is behaving as expected:
deliverAt.deliverAt.Update misleading godoc for
Popreceiver.Addresses #209 (comment)