Allow skipping to future rounds from QUALITY phase #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 71.22% 71.22% -0.01%
==========================================
Files 33 33
Lines 2440 2433 -7
==========================================
- Hits 1738 1733 -5
+ Misses 571 570 -1
+ Partials 131 130 -1
|
masih
force-pushed
the
masih/allow-skip-quality-round
branch
2 times, most recently
from
fb72402 to
654eb3b
Compare
|
Fuzz test failed on commit 654eb3b. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9270638776 -n testdataAleternatively, download directly from here. |
Update the core protocol implementation to allow skipping to future rounds from QUALITY phase. This reduces the conditions to requiring an instance to only fully execute DECIDE phase. Otherwise, the instance may jump ahead as long as all queued messages are processed. As a result, the implementation no longer needs to check for QUALITY phase transition on receiving alarms. Fixes #278
masih
force-pushed
the
masih/allow-skip-quality-round
branch
from
654eb3b to
92d1d5b
Compare
anorth
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the core protocol implementation to allow skipping to future rounds from QUALITY phase. This reduces the conditions to requiring an instance to only fully execute DECIDE phase. Otherwise, the instance may jump ahead as long as all queued messages are processed.
As a result, the implementation no longer needs to check for QUALITY phase transition on receiving alarms.
Fixes #278