Enforce size limits on TipSet key and power table CID length. #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 85.20% 84.90% -0.31%
==========================================
Files 14 14
Lines 1467 1477 +10
==========================================
+ Hits 1250 1254 +4
- Misses 136 139 +3
- Partials 81 84 +3
|
Stebalien
approved these changes
Jun 4, 2024
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM modulo a few suggestions. Also, we should probably have a few tests with bad CIDs/tipsets.
Kubuxu
approved these changes
Jun 6, 2024
Contributor
Kubuxu
left a comment
Kubuxu
left a comment
There was a problem hiding this comment.
SGWM (although @Stebalien suggestions are good as well)
anorth
force-pushed
the
anorth/tipset-limits
branch
from
0f0c3e2 to
b8d2507
Compare
anorth
force-pushed
the
anorth/tipset-limits
branch
from
b8d2507 to
a3d2c83
Compare
Stebalien
reviewed
Jun 7, 2024
Stebalien
approved these changes
Jun 7, 2024
Member
|
(needs a make gen) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303