Error out fatally when strong quorum exists but not found #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When quorum state dictates that a strong qorum is present, then there must be a corresponding `QuorumResult`. If it is not found, then it is an indication of corrupt internal state most-likey caused by a bug. In which case, error fatally. Fixes #234
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
==========================================
- Coverage 85.33% 85.22% -0.11%
==========================================
Files 14 14
Lines 1459 1462 +3
==========================================
+ Hits 1245 1246 +1
- Misses 136 137 +1
- Partials 78 79 +1
|
Kubuxu
approved these changes
Jun 6, 2024
Stebalien
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quorum state dictates that a strong qorum is present, then there must be a corresponding
QuorumResult. If it is not found, then it is an indication of corrupt internal state most-likey caused by a bug. In which case, error fatally.Fixes #234