Save decisions in certstore #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Based on #320 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 82.88% 82.92% +0.04%
==========================================
Files 15 15
Lines 1683 1687 +4
==========================================
+ Hits 1395 1399 +4
Misses 168 168
Partials 120 120
|
Stebalien
approved these changes
Jun 7, 2024
| if err != nil { | ||
| return xerrors.Errorf("forming certificate out of decision: %w", err) | ||
| } | ||
| err = h.client.certstore.Put(h.runningCtx, cert) |
Member
There was a problem hiding this comment.
IMO, we should spend the extra time and validate this certificate. We can either do that inside the certstore, or here.
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Stebalien
approved these changes
Jun 12, 2024
| if err != nil { | ||
| return xerrors.Errorf("forming certificate out of decision: %w", err) | ||
| } | ||
| _, _, _, err = certs.ValidateFinalityCertificates(h, h.NetworkName(), current.Entries, decision.Vote.Instance, cert.ECChain.Base()) |
Member
There was a problem hiding this comment.
note: you don't need to pass the base. If you pass nil, it'll just ignore it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.