Use consistent request broadcast pattern in simulated sync broadcasts #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 15 15
Lines 1687 1687
=======================================
Hits 1399 1399
Misses 168 168
Partials 120 120 |
masih
force-pushed
the
masih/sim-sync-broadcast
branch
2 times, most recently
from
4e97ca7 to
c9f4f21
Compare
Stebalien
approved these changes
Jun 12, 2024
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
This seems reasonable, but if you want deeper design feedback I don't have enough context. But if you're just looking for a LGTM, go ahead and merge it.
Member
|
Removing auto-marge because I'm not sure how much feedback @masih is looking for. |
Member
Author
|
Thank you Steven for excellent feedback as always |
anorth
approved these changes
Jun 12, 2024
masih
force-pushed
the
masih/sim-sync-broadcast
branch
from
c9f4f21 to
3fd8b4e
Compare
To implement some adversary models the simulation package introduces an interface that allows an adversary host to immediately propagate a message across the network. Since the original implementation the core broadcast mechanisms has evolved into async `RequestBroadcast` that takes a builder. But the pattern is not fully applied to the simulation specific flavour of synchronous broadcast. The changes here use the same builder pattern in simulation and reflect changes across adversary models.
masih
force-pushed
the
masih/sim-sync-broadcast
branch
from
3fd8b4e to
388b79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement some adversary models the simulation package introduces an interface that allows an adversary host to immediately propagate a message across the network.
Since the original implementation the core broadcast mechanisms has evolved into async
RequestBroadcastthat takes a builder. But the pattern is not fully applied to the simulation specific flavour of synchronous broadcast.The changes here use the same builder pattern in simulation and reflect changes across adversary models.