Wait for boostrap epoch and boostrap CertStore power table from it #354
Conversation
Kubuxu
force-pushed
the
feat/wait-for-boostrap
branch
from
8dec701 to
c898ac3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 83.20% 83.10% -0.10%
==========================================
Files 15 15
Lines 1780 1782 +2
==========================================
Hits 1481 1481
- Misses 174 175 +1
- Partials 125 126 +1
|
Kubuxu
force-pushed
the
feat/wait-for-boostrap
branch
from
c898ac3 to
ac80fcc
Compare
|
Fuzz test failed on commit 8dec701. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9582906729 -n testdataAleternatively, download directly from here. |
|
Fuzz test failed on commit ac80fcc. To troubleshoot locally, download the seed corpus using GitHub CLI by running: gh run download 9582990060 -n testdataAleternatively, download directly from here. |
Kubuxu
force-pushed
the
feat/wait-for-boostrap
branch
2 times, most recently
from
e0e8ab7 to
e8bef1b
Compare
Kubuxu
changed the title
|
@Stebalien this is a bit nasty, I need it to unblock me on lotus |
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
This will probably be fine given that nothing really happens outside of Run (assuming that's the case?). I don't like, but it'll probably be fine.
f3.go
Outdated
| select { | ||
| case <-time.After(aim): | ||
| case <-ctx.Done(): | ||
| return nil |
| } | ||
|
|
||
| // Run start the module. It will exit when context is cancelled. | ||
| func (m *F3) Run(initialInstance uint64, ctx context.Context) error { |
There was a problem hiding this comment.
unrelated, we should get the initial instance from the certificate store.
f3.go
Outdated
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() | ||
|
|
||
| if m.CertStore == nil { |
There was a problem hiding this comment.
Make the certstore private or someone will trip over it.
Also fix a off-by-one in GetTipsetByEpoch Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Signed-off-by: Jakub Sztandera <oss@kubuxu.com>
Kubuxu
force-pushed
the
feat/wait-for-boostrap
branch
from
ab1c684 to
b7e417e
Compare
|
Merging to unblock further work |
Also fix a off-by-one in GetTipsetByEpoch