Skip to content

fix: validate chain proposal length against chain exchange max length #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kubuxu merged 1 commit into from
Apr 16, 2025
Merged

fix: validate chain proposal length against chain exchange max length #942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions manifest/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,8 @@ func (m *Manifest) Validate() error {
if err := m.PartialMessageManager.Validate(); err != nil {
return fmt.Errorf("invalid manifest: invalid partial message manager config: %w", err)
}
if m.ChainExchange.MaxChainLength > m.Gpbft.ChainProposedLength {
return fmt.Errorf("invalid manifest: chain exchange max chain length %d exceeds gpbft proposed chain length %d", m.ChainExchange.MaxChainLength, m.Gpbft.ChainProposedLength)
if m.Gpbft.ChainProposedLength > m.ChainExchange.MaxChainLength {
return fmt.Errorf("invalid manifest: chain proposal length %d is greater than chain exchange max chain length %d", m.Gpbft.ChainProposedLength, m.ChainExchange.MaxChainLength)
}
if m.ChainExchange.MaxInstanceLookahead > m.CommitteeLookback {
return fmt.Errorf("invalid manifest: chain exchange max instance lookahead %d exceeds committee lookback %d", m.ChainExchange.MaxInstanceLookahead, m.CommitteeLookback)
Expand Down
Loading