Bug: CommandManager.OverwriteKeyBindings System.ArgumentException

[yaira2]

Description

System.ArgumentException: An element with the same key but a different value already exists. Key: 'Alt+Ctrl+Haut'

Steps To Reproduce

NA

Requirements

• Fix crash

Files Version

v3.4

Windows Version

Windows 11

Log File

System.Collections.Immutable.ImmutableDictionary`2
HashBucket.Add (TKey key, TValue value, IEqualityComparer`1 keyOnlyComparer, IEqualityComparer`1 valueComparer, KeyCollisionBehavior behavior, OperationResult& result)
System.Collections.Immutable
ImmutableDictionary`2.AddRange (IEnumerable`1 items, MutationInput origin, KeyCollisionBehavior collisionBehavior)
System.Collections.Immutable
ImmutableDictionary`2.AddRange (IEnumerable`1 pairs, Boolean avoidToHashMap)
Files.App.Data.Commands
CommandManager.OverwriteKeyBindings ()
Files.App.Utils.Serialization
BaseObservableJsonSettings.Set[TValue] (TValue value, String propertyName)
Files.App.Services.Settings
ActionsSettingsService.set_ActionsV2 (List`1 value)
Files.App.ViewModels.Settings
ActionsViewModel.ExecuteSaveCommand (ModifiableActionItem item)
CommunityToolkit.Mvvm.Input
RelayCommand`1.Execute (Object parameter)
ABI.System.Windows.Input.ICommand
Vftbl.Do_Abi_Execute_3 (IntPtr thisPtr, IntPtr parameter)
WinRT
ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0 (Int32 hr)
ABI.Windows.ApplicationModel.Core
IUnhandledErrorMethods.Propagate (IObjectReference _obj)
Microsoft.AppCenter.Utils
ApplicationLifecycleHelperWinUI.<ctor>b__0_3 (Object sender, UnhandledErrorDetectedEventArgs eventArgs)

[0x5bfa]

Yeah when user set the same key to different commands, this happens. I’ve ever seen this crash before once.

before adding keybindings to dictionary, we can check if.

[yaira2]

Yeah when user set the same key to different commands

Don't we already prevent duplicate key bindings?

[0x5bfa]

If user set via text editor, we cannot prevent beforehand.

[0x5bfa]

Oh, sorry. I didn't know this issue was urgent

P.S. Sorry again, closed mistakenly