Fix: Fixed ArgumentException in CommandManager.OverwriteKeyBindings

[0x5bfa]

Summary

The fix is basically to catch exceptions and use default keys for commands that have the same key(if other exception than ArgumentException the app uses the default keys for all commands).

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

• Closes Bug: CommandManager.OverwriteKeyBindings System.ArgumentException #15331

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

1. Set the same key *1
2. Open Files app
3. See no crashes

Used this to test

  "ActionsV2": [
    {
      "CommandCode": "OpenHelp",
      "CommandParameter": "",
      "KeyBinding": "F1"
    },
    {
      "CommandCode": "OpenHelp",
      "CommandParameter": "",
      "KeyBinding": "Ctrl+C"
    }
  ],

[hishitetsu]

Crashes can be avoided, but changing duplicate key assignments from the settings doesn't seem to be saved.

[0x5bfa]

I want to reset them in json too then
@yaira2 fyi

[hishitetsu]

This can only happen by editing the configuration file directly, so I think it is fine to leave it as it is if avoiding crashes is enough.

[0x5bfa]

I mean, instead of using default ones, I'd like to reset in json first and reload. What do you think? Losing user data without notice would be bad but this reload happens before MainPage loaded, meaning dialog cannot be shown.

[hishitetsu]

I mean, instead of using default ones, I'd like to reset in json first and reload. What do you think? Losing user data without notice would be bad but this reload happens before MainPage loaded, meaning dialog cannot be shown.

I don't think it is a good idea, unless structure of the json is broken.

[0x5bfa]

Okay, I’ll just fix

[hishitetsu]

It seems that the app no longer starts when there is a duplicate key.

[0x5bfa]

Proven I’m bad at bug fix.
Let me take a look tonight.

[hishitetsu]

I confirmed it works. LGTM

[yaira2]

What solution did we end up going with?

[hishitetsu]

If there are any custom hotkeys that duplicate other hotkeys, they are removed from the json and restored to default.

[yaira2]

Thank you @0x5bfa and @hishitetsu for your work on this fix!