Bug: Crash when clicking on the Explorer icon

[Ultra119]

Description

Crashes when clicking on the Explorer icon more than once, with the "Set Files as the default file manager" option enabled.

Steps To Reproduce

1. Turn on "Set Files as the default file manager"
2. Close Files
3. Click on the Explorer twice or more

Requirements

• Fix Files crash when clicking on the Explorer icon more than once with the "Set Files as default file manager" option enabled

Files Version

3.5.6 / 3.5

Windows Version

10.0.22631

Log File

debug.log

[Josh65-2201]

Thanks for the report. The log doesn't show any crash errors.

• What explorer icon do you mean? Is it a shortcut to Windows File Explorer on the desktop or the recycle bin/my computer icon
• Are you able to open Files normally from the start menu?

[Ultra119]

Thanks for the report. The log doesn't show any crash errors.

• What explorer icon do you mean? Is it a shortcut to Windows File Explorer on the desktop or the recycle bin/my computer icon
• Are you able to open Files normally from the start menu?

I apologize for the understatement. Above, I was referring to opening through the Windows Explorer icon on the taskbar. But the same happens with any Explorer-related icon on the desktop, including the Recycle bin. A black Files window opens for a split second and then disappears

[0x5bfa]

It’s weird that the log has nothing to indicate.
Could you try to find Files app from Windows logs > Application > sort by Source > .NET Runtime in Event Viewer?

[Ultra119]

It’s weird that the log has nothing to indicate. Could you try to find Files app from Windows logs > Application > sort by Source > .NET Runtime in Event Viewer?

Level	Date and Time	Source	Event ID	Task Category
Error	7/7/2024 12:27:03 AM	Application Error	1000	Application Crashing Events	"Faulting application name: Files.exe, version: 1.0.0.0, time stamp: 0x66470000
Faulting module name: KERNELBASE.dll, version: 10.0.22621.3733, time stamp: 0x44653e19
Exception code: 0xe0434352
Fault offset: 0x000000000005f39c
Faulting process id: 0x0x26F4
Faulting application start time: 0x0x1DACFEB3E331178
Faulting application path: C:\Program Files\WindowsApps\FilesPreview_3.5.6.0_x64__1y0xx7n9077q4\Files.App\Files.exe
Faulting module path: C:\Windows\System32\KERNELBASE.dll
Report Id: 3e75406c-2d40-43c5-baac-48d5c573a1a9
Faulting package full name: FilesPreview_3.5.6.0_x64__1y0xx7n9077q4
Faulting package-relative application ID: App"
Error	7/7/2024 12:27:03 AM	.NET Runtime	1026	None	"Application: Files.exe
CoreCLR Version: 8.0.624.26715
.NET Version: 8.0.6
Description: The process was terminated due to an unhandled exception.
Exception Info: System.ArgumentNullException: Value cannot be null. (Parameter 'logger')
   at System.ThrowHelper.Throw(String paramName)
   at Microsoft.Extensions.Logging.LoggerExtensions.Log(ILogger logger, LogLevel logLevel, EventId eventId, Exception exception, String message, Object[] args)
   at Files.App.App.OnActivatedAsync(AppActivationArguments activatedEventArgs)
   at Files.App.Program.OnActivated(Object sender, AppActivationArguments args)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
"
Error	7/7/2024 12:27:00 AM	.NET Runtime	1000	None	"Category: Files.App.App
EventId: 0

Value cannot be null. (Parameter 'source')

Exception: 
System.ArgumentNullException: Value cannot be null. (Parameter 'source')
   at System.Linq.ThrowHelper.ThrowArgumentNullException(ExceptionArgument argument)
   at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found)
   at Files.App.ViewModels.ShellViewModel.CheckForBackgroundImage()
   at CommunityToolkit.WinUI.DispatcherQueueExtensions.EnqueueAsync(DispatcherQueue dispatcher, Action function, DispatcherQueuePriority priority)
--- End of stack trace from previous location ---
   at Files.Shared.Extensions.SafetyExtensions.IgnoreExceptions(Func`1 action, ILogger logger, Type exceptionToIgnore)
   at Files.App.ViewModels.ShellViewModel.LayoutModeChangeRequested(Object sender, LayoutModeEventArgs e)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
   at Microsoft.UI.Dispatching.DispatcherQueueSynchronizationContext.<>c__DisplayClass2_0.<Post>b__0()
"

That's all

[0x5bfa]

Nice!

@Ultra119 It looks like it’s crashing when checking background image from the INI file. Could you paste the file here?