Code Quality: Replace `string.GetLocalizedResource()` with `Strings.object.GetLocalizedResource()`

[Lamparter]

Description

Using "StringName".GetLocalizedResource() can cause issues when strings are renamed or removed as it makes it harder to see where strings are to replace them.
This should be replaced with Strings.StringName.GetLocalizedResource() across multiple PRs.

Concerned code

• src/Files.App

This should probably be split up into multiple PRs e.g. for views/viewmodels, Actions, and the rest of the codebase, to make it easier to review.

Gains

• Easier to tell where strings are
• Can fix issues with string display if they are removed

Requirements

• Replace "{0}".GetLocalizedResource with Strings.{0}.GetLocalizedResource across multiple PRs

Comments

No response

[yaira2]

We implemented this a couple of months ago and have been updating old references as we modify existing classes.

[Lamparter]

There are still so many (200+) references

[yaira2]

Our approach is to implement these kinds of changes only to files that are already being modified. This minimizes the need for additional code reviews and ensures all modifications are thoroughly tested.

[Lamparter]

If you’d be willing to split it into smaller PRs, I’d be able to review them more effectively without GitHub freezing

@yaira2 that's what I suggested here

This should probably be split up into multiple PRs e.g. for views/viewmodels, Actions, and the rest of the codebase, to make it easier to review.

In that case, you might want to reopen the issue

[yaira2]

Ideally, we’d only update classes that are already being modified. That said, this is an improvement and can be implemented through several smaller PRs.