Bug: Slow file selection when Recycle Bin has many files

[muko]

Description

Selecting files can cause noticeable delays, especially when the Recycle Bin contains a large number of items.

SHQueryRecycleBin() can be slow (over 1 second) when the Recycle Bin is large, and ToolBar.PopulateToolbarItems() is called multiple times per selection leads to UI lag.

ToolBar.PopulateToolbarItems()
   -> ...
        -> TrashBinService.QueryRecycleBin()
            -> PInvoke.SHQueryRecycleBin()

Steps To Reproduce

1. Fill the Recycle Bin with a large number of files
2. Execute Files
3. Navigate to a folder
4. Change file selection repeatedly

Files Version

4.0.40.0

Windows Version

10.0.26100

User ID

No response

Log File

no log files

[Josh65-2201]

Thanks for the feedback, we're tracking this in the below linked issue. You can check there or click subscribe in the right sidebar for updates.

[yair100]

@muko are you able to reproduce this in main? There is a change that should help but it would be great if you can confirm.

[yair100]

Thanks for the feedback, we're tracking this in the below linked issue. You can check there or click subscribe in the right sidebar for updates.

@Josh65-2201 #18289 is a different issue with the selection rectangle. The issue @muko is reporting is a little different.

[muko]

I’ve opened a PR for this: #18422

I linked #18289, bu it should also help with this issue.
It reduces redundant calls to PopulateToolbarItems(), which seem to be a major source of the slowdown.

[yair100]

Did you check if this still occurs in main? I would hold off creating a PR for now.

[muko]

This issue still occurs on the latest main (commit: 1425850).

When PInvoke.SHQueryRecycleBin() returns queryBinInfo.i64NumItems = 3378, the API call takes about 7.5 seconds.

As a result, selecting a file can take up to 40 seconds.

With PR #18422, this is reduced to about 24 seconds, and with PR #18424, it is reduced to under 1 second.