Icon Property Issue

[timcrouse]

Description

Setting custom icons does not work as intended (at least in the favorites pane):

Setting a custom icon may cause the app to crash. But when you restart it the icon is set to the selected icon.

Changing the icon may generate a dialog stating the drive is unplugged when the folder being changed is a folder on the C: drive. After you close and re-open the app the icon is set to the desired icon.

-Tim C.

Steps To Reproduce

Goto favorites pane
Right click folder
Change icon property

Expected behavior

expect icon to change

Files Version

2.1.15.0

Windows Version

10.0.19044

Relevant Assets/Logs

debug_fulltrust.log
debug.log

[Josh65-2201]

Is this still an issue?

[timcrouse]

Has there been an update to the app? I can reload and test if you whish. I see no version info in the app or on the GitHub or Microsoft store site. Version info and release date would be good info to include.

…

-Tim Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: ***@***.***> Sent: Sunday, July 10, 2022 10:21 PM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) Is this still an issue? — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IMW66I7S23H3K6ZNITVTOAKXANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Josh65-2201]

theres version info in the app settings > about. and on github it on the code section under realses.

[timcrouse]

The latest build seems to be 2.3.3, noted at 2.3 on MS app store). This is the version I have installed. If you have a new release I can test the issue but as it stands the issue is still present on my machine.

…

-Tim Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: ***@***.***> Sent: Wednesday, July 13, 2022 8:59 AM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) theres version info in the app settings > about. and on github it on the code section under realses. — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IL6BNMKGE2M32JNYKLVT24UFANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[timcrouse]

I have not found a compiled executable with a newer build on GitHub. But there does seem to be something called a sideload build that was created 2 months ago. But again, there is no executable. -Tim Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: ***@***.***> Sent: Wednesday, July 13, 2022 8:59 AM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) theres version info in the app settings > about. and on github it on the code section under realses. — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IL6BNMKGE2M32JNYKLVT24UFANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Josh65-2201]

2.3.3 is the lastest version but in your issue you were on 2.1.15. Thats why i asked if it was still an issue

[timcrouse]

Hmm, must of crossed something up on my end. I will re-check Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: ***@***.***> Sent: Wednesday, July 13, 2022 12:02 PM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) 2.3.3 is the lastest version but in your issue you were on 2.1.15. Thats why i asked if it was still an issue — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IO6C6M5AAFIEZNRAA3VT3SARANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[timcrouse]

So here are the results from 2.3.3 R-click icon in favorites pane Option to change icon is no longer available Go to close r-click properties dialog App crashes. Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows

…

________________________________ From: Josh-65 ***@***.***> Sent: Wednesday, July 13, 2022 12:02:16 PM To: files-community/Files ***@***.***> Cc: timcrouse ***@***.***>; Author ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) 2.3.3 is the lastest version but in your issue you were on 2.1.15. Thats why i asked if it was still an issue — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IO6C6M5AAFIEZNRAA3VT3SARANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[timcrouse]

The crash does NOT occur each time the properties dialog is closed. Seems to happen at random Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows From: ***@***.***> Sent: Wednesday, July 13, 2022 12:02 PM To: ***@***.***> Cc: ***@***.***>; ***@***.***> Subject: Re: [files-community/Files] Icon Property Issue (Issue #9000) 2.3.3 is the lastest version but in your issue you were on 2.1.15. Thats why i asked if it was still an issue — Reply to this email directly, view it on GitHub<#9000 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGW34IO6C6M5AAFIEZNRAA3VT3SARANCNFSM5UI3WTRQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[Josh65-2201]

Could you try recreate the issue then upload the logs files directly to github. You can get them in files settings > about > open log folder.