Bug: Fixed issue where Rotate Image & Set as Wallpaper were sometimes not displayed

[marcofranzen99]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: IsExecutable for Set as Background action is broken #11810

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Rotate & Select As Background Image are hidden if no item is selected
  2. Rotate & Select As Background Image are hidden if a non image file is selected
  3. Rotate & Select As Background Image are visible if an image is selected
  4. Set as desktop slideshow is visible if multiple images are selected

[marcofranzen99]

It might be better if the ViewModel would update the state itself so you don't have to call the method CheckAllFileExtensions in all three Actions but I couldn't find an easy way to implement this

[yaira2]

It might be better if the ViewModel would update the state itself so you don't have to call the method CheckAllFileExtensions in all three Actions but I couldn't find an easy way to implement this

Once we're finished with implementing the actions, we can look into improving the way they access the context as well as the code it uses to execute the logic.

[ferrariofilippo]

It might be better if the ViewModel would update the state itself so you don't have to call the method CheckAllFileExtensions in all three Actions but I couldn't find an easy way to implement this

What about an abstract parent BaseSetAsAction so that we can share the code?

[marcofranzen99]

What about an abstract parent BaseSetAsAction so that we can share the code?

This does not change the fact that the method CheckAllFileExtensions is called in each action. But it is a good idea to avoid the duplicate code. I will create the abstract class later

[ferrariofilippo]

This does not change the fact that the method CheckAllFileExtensions is called in each action. But it is a good idea to avoid the duplicate code. I will create the abstract class later

Saving the result in a static property?

[marcofranzen99]

Saving the result in a static property?

I am not sure if that is possible, at least I couldn't get something like that to work

[yaira2]

LGTM

[hishitetsu]

Please rename this too.

Files/src/Files.App/Commands/CommandCodes.cs

Lines 80 to 82 in 344a890

	// Image Edition
	RotateLeft,
	RotateRight,

[yaira2]

LGTM

[yaira2]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).