Fix: Don't clear multiselect on hover if the item is part of the selection

[marcofranzen99]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: Multiselect is getting cleared when select on hover is enabled #11867

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Hovering over multiple selected items won't clear selection
  2. Hovering over not selected items will clear the multi selection & select the new item

Screenshots (optional)

Files_e8IZ9jm00I.mp4

Notes
The first commit inverts two conditions and uses return to save some indentation
The second commit is the actual fix

[yaira2]

Hovering over not selected items will clear the multi selection & select the new item

This isn't desired, if multiple items are already selected, we should ignore the select on hover feature.

[marcofranzen99]

This isn't desired, if multiple items are already selected, we should ignore the select on hover feature.

That makes sense, i have updated the code accordingly and also the video where I tested the changes in the PR description

[yaira2]

I think this can be simplified by modifying the if statement on line 1101 to return if multiple files are selected.

[marcofranzen99]

I think this can be simplified by modifying the if statement on line 1101 to return if multiple files are selected.

That was also my first thought, but then it wouldn't work to select multiple items by pressing Shift or Control. The code for that is between line 1116 and 1136.

This condition even expects that at least one item is selected https://github.com/files-community/Files/blob/main/src/Files.App/BaseLayout.cs#L1121

[yaira2]

Looks good to me, can you add some comments to the code?

[marcofranzen99]

Looks good to me, can you add some comments to the code?

I added some basic comments, I think the other parts are pretty self explaining or is there any specific part where I should add a comment?

[yaira2]

Looks good, thanks!