Code Quality: LiteDB server and Files.Core removal #14911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hez2010
changed the title
yaira2
force-pushed
the
main
branch
2 times, most recently
from
edf33f7 to
c79b2cb
Compare
Member
|
Maybe Core removal should be separated for the code review. |
d2dyno1
reviewed
Apr 1, 2024
| col.Delete(tmp.Id); | ||
| } | ||
| } | ||
| NormalMaxLength = entry.NormalMaxLength, |
Member
There was a problem hiding this comment.
I assume everything is saved to the DB transparently, right?
Member
Author
There was a problem hiding this comment.
This is to convert LayoutPreferencesItem from Files.App to LayoutPreferencesItem from Files.App.Server. We cannot just simply move the LayoutPreferencesItem from Files.App to Files.App.Server as it contains a lot of services related to UI.
And yeah, changes will be saved to the DB.
Member
Author
|
PTAL |
0x5bfa
approved these changes
Apr 3, 2024
yaira2
reviewed
Apr 3, 2024
yaira2
changed the title
yaira2
added
ready to merge
8 tasks
marianalcar
pushed a commit
to marianalcar/Files
that referenced
this pull request
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Microsoft.UI.Content.ContentExternalOutputLinkfrom winmd on-the-fly to avoid breaking changes in CsWinRTValidation
How did you test these changes?
Screenshots (optional)
Add screenshots here.