Skip to content

Conversation

@marcofranzen99
Copy link
Contributor

Resolved / Related Issues

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

Test Cases
Hidden status is saved and displayed correctly directly in the UI if only one file is selected

  • Select a file, open properties, select hidden + save
  • The file is now displayed directly in the list as hidden
  • Open properties again and check whether hidden status is set

Hidden status is saved and displayed correctly directly in the UI when multiple files are selected

  • Select multiple files, select hidden + save
  • The files are now displayed directly in the list as hidden
  • Open properties again and check whether hidden status is set

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 28, 2024
@yaira2 yaira2 changed the title Fix: Fixed an issue where it was not possible to edit the properties of multiple items simultaneously Fix: Fixed issue with editing properties of multiple items at the same time Mar 28, 2024
@hishitetsu
Copy link
Member

hishitetsu commented Mar 30, 2024

There is a glitch in the following step.

  1. Select hidden and non-hidden files together.
  2. Open the properties window.
  3. Press the Save button.
  4. The list appears as if the hidden attribute has been removed, but in fact it has not.

It might be better to put the checkbox in the third state when hidden and non-hidden files are selected together.

@marcofranzen99
Copy link
Contributor Author

marcofranzen99 commented Mar 31, 2024

It might be better to put the checkbox in the third state when hidden and non-hidden files are selected together.

Good idea, thank you

I did the same for the readonly file attribute

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 31, 2024
@yaira2 yaira2 merged commit 7cde881 into files-community:main Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Unable to edit the properties of multiple items simultaneously

3 participants