Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 29, 2024

Summary

Merged:

  • FileUtils
  • InteropHelpers
  • NativeDirectoryChangesHelper

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    None

Screenshots

None

@yaira2
Copy link
Member

yaira2 commented Mar 31, 2024

How were each of these methods tested to ensure everything is functioning as before?

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Mar 31, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 31, 2024

Obviously ensured safely because I just moved and added comments.

@yaira2 yaira2 merged commit 58552ac into files-community:main Mar 31, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Mar 31, 2024
@0x5bfa 0x5bfa deleted the 5bfa/CQ-ReplaceWithCsWin32 branch April 1, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants