Skip to content

Conversation

@gumbarros
Copy link
Contributor

@gumbarros gumbarros commented Apr 1, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Related to Code Quality: Fix CA1859 and CA1829 #14955

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

It's the same of CA1859, but I ran all Rider analyzers in the solution and found CA1859 in another name.
image

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gumbarros gumbarros changed the title RoslynAnalyzers: Use concrete types when possible for improved performance Code Quality: Use concrete types when possible for improved performance Apr 4, 2024
@yaira2 yaira2 force-pushed the main branch 3 times, most recently from 32de19b to ba56951 Compare April 4, 2024 21:47
@yaira2 yaira2 requested a review from d2dyno1 April 7, 2024 16:54
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Apr 7, 2024
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The performance impact is negligible, but it looks ok
LGTM

@yaira2 yaira2 merged commit fb1d003 into files-community:main Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants