Skip to content

Conversation

@marcelwgn
Copy link
Contributor

@marcelwgn marcelwgn commented Apr 1, 2024

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes #issue...
    Discussed with @yaira2 , this PR aims to fix the small gap visible on the items that are part of the path but are not the last item when they are hovered as shown on the screenshot below:
    Screenshot of small gap on hovered item

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open app ...
    2. Click settings button ...

Screenshots (optional)
Add screenshots here.

{
var presenter = args.ItemContainer.FindDescendant<Grid>()!;
presenter!.Background = this.Resources["ListViewItemBackgroundSelected"] as SolidColorBrush;
SetFolderBackground(args.ItemContainer as ListViewItem, this.Resources["ListViewItemBackgroundSelected"] as SolidColorBrush);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make this theme aware to fix #12577?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, the only option would be to listen to theme changes and based on that reapply the background. Unfortunately, there is no code behind way to create a ThemeResouce binding (at none that I am aware of).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding logic for that or should we leave as is since restarting the app will use the correct theme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda depends on how urgent a fix is in your opinion. On App startup, the theme should match OS theme however if you change it during runtime, we might not know it. Given we use this.Resources the layout might have picked up the OS theme quite late in the lifecycle though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've only had one bug report so it's not the highest priority, if it's a simple fix I guess we should move forward but otherwise it's not worth it if it requires a complex workaround.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not too hard, we would probably only need an event listener for the actual theme changed event. I'll add a comment to the issue in case anyone else wants to pick it up (and make it easier for newcomers to contribute)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 changed the title Fix issue of overlapping brushes leaving gap on column layout Fix: Fixed issue of overlapping brushes leaving gap on column layout Apr 1, 2024
@yaira2 yaira2 changed the title Fix: Fixed issue of overlapping brushes leaving gap on column layout Fix: Fixed issue of overlapping brushes leaving gap in the Columns View Apr 1, 2024
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 1, 2024
@yaira2 yaira2 merged commit be0ab46 into files-community:main Apr 1, 2024
@marcelwgn marcelwgn deleted the dev/fix-column-highlight-overlapping branch April 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants