-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Feature: Improved the display of keyboard shortcuts in the Command Palette #15106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yaira2
merged 5 commits into
files-community:main
from
0x5bfa:5bfa/Feature-AddKeyboardShortcutControl
Apr 3, 2024
Merged
Feature: Improved the display of keyboard shortcuts in the Command Palette #15106
yaira2
merged 5 commits into
files-community:main
from
0x5bfa:5bfa/Feature-AddKeyboardShortcutControl
Apr 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
reviewed
Apr 2, 2024
20 tasks
Member
Author
|
@hishitetsu Is secondary display and supplymentary display used no longer in this PR? If so, I'd like to remove them in this PR. |
Member
Member
Author
|
Thanks. |
yaira2
previously approved these changes
Apr 3, 2024
Member
yaira2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
|
@0x5bfa can you try to center the text vertically? |
…hub.com/0x5bfa/Files into 5bfa/Feature-AddKeyboardShortcutControl
yaira2
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
As the title.
PR Checklist
Closes Feature: Improve keyboard shortcut display #13200
Screenshots