Skip to content

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Apr 2, 2024

Summary

As the title.

PR Checklist

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Improve keyboard shortcut display #13200
  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Open Command Palette with no words

Screenshots

image

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Apr 2, 2024
@yaira2 yaira2 changed the title Feature: Added a keyboard shortcut collection control Feature: Improved the display of keyboard shortcuts in the Command Palette Apr 2, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 3, 2024

@hishitetsu Is secondary display and supplymentary display used no longer in this PR? If so, I'd like to remove them in this PR.

@hishitetsu
Copy link
Member

They were originally intended to be displayed on two lines, one in the native language and one in English, as in VSCode. If we don't plan to do so, you may remove them.
image

@0x5bfa
Copy link
Member Author

0x5bfa commented Apr 3, 2024

Thanks. I will remove for now. Will remove in the future.

yaira2
yaira2 previously approved these changes Apr 3, 2024
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Apr 3, 2024

@0x5bfa can you try to center the text vertically?
image

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Apr 3, 2024
@yaira2 yaira2 merged commit 2a1a427 into files-community:main Apr 3, 2024
@0x5bfa 0x5bfa deleted the 5bfa/Feature-AddKeyboardShortcutControl branch April 3, 2024 20:22
marianalcar pushed a commit to marianalcar/Files that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Improve keyboard shortcut display

3 participants